risdenk commented on code in PR #1482:
URL: https://github.com/apache/solr/pull/1482#discussion_r1146206689
##########
solr/core/src/java/org/apache/solr/search/facet/UniqueAgg.java:
##########
@@ -85,7 +85,7 @@ public void merge(Object facetResult, Context mcontext) {
List<?> vals = (List<?>) map.get(VALS);
if (vals != null) {
if (values == null) {
- values = new HashSet<>(vals.size() * 4);
+ values = CollectionUtil.newHashSet(vals.size() * 4);
Review Comment:
I agree that some of the other * some multiple seem suspicious. I'll take a
look. at least in UniqueAgg, I don't know what the size should be at all. Its
not clear :/ Its been *4 since 2015 when it was added so going to leave it for
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
