risdenk commented on code in PR #1482:
URL: https://github.com/apache/solr/pull/1482#discussion_r1146207813
##########
solr/core/src/java/org/apache/solr/search/join/ScoreModeParser.java:
##########
@@ -29,7 +29,7 @@ class ScoreModeParser {
private ScoreModeParser() {}
private static Map<String, ScoreMode> getLowerAndCapitalCaseMap() {
- Map<String, ScoreMode> map = new HashMap<>(ScoreMode.values().length * 2);
+ Map<String, ScoreMode> map =
CollectionUtil.newHashMap(ScoreMode.values().length * 2);
Review Comment:
`*2` I think is correct here since for each value two items are put in the
map:
```
map.put(s.name().toLowerCase(Locale.ROOT), s);
map.put(s.name(), s);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]