epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1148546799
##########
solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java:
##########
@@ -307,16 +340,24 @@ public void
testDeleteByIdCompositeRouterWithRouterField() throws Exception {
// including cloudClient helps us test view from other nodes
that aren't the
// leaders...
for (SolrClient c : Arrays.asList(cloudClient, shard1, shard2)) {
+ String queryWithCollectionName =
Review Comment:
i definilty felt icky on this one... sometimes it's a string value and
sometimes it's a null.... going to look again...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
