epugh commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1148551005
##########
solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java:
##########
@@ -258,25 +278,38 @@ public void testDeleteByIdImplicitRouter() throws
Exception {
}
}
+ private String specifyCollectionParameterForCloudSolrClient(
+ SolrClient solrClient, String collectionName) {
+ // For CloudSolrClient we must specify the collection name as a parameter,
+ // however for shard1 and shard2, it's already part of the URL so we can
specify a null
+ // parameter. The
+ // instanceof check makes that decision.
+ String collectionNameRequiredParameter = null;
+ if (solrClient instanceof CloudSolrClient) {
+ collectionNameRequiredParameter = collectionName;
+ }
+ return collectionNameRequiredParameter;
Review Comment:
ended up removing this method... Yeah, it was icky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
