epugh commented on PR #1499: URL: https://github.com/apache/solr/pull/1499#issuecomment-1488352844
> For simple URL -> SolrClient (no further customization), I admit the STCJ4 method was nice. Can we keep these and just focus here on anything else? Sure! Do you think we keep this name? ``` collection1 = getHttpSolrClient(url + "/collection1"); ``` or maybe change it to ``` collection1 = getSolrClient(url + "/collection1"); ``` ? I guess I am wondering if the `Http` part matters... Thinking that if Http matters, then you should use a Builder... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
