dsmiley commented on PR #1499: URL: https://github.com/apache/solr/pull/1499#issuecomment-1489340812
> CloudSolrClient getCloudSolrClient(String zkHost) --> 5 usages in 3 files Let's lose it. > CloudSolrClient getCloudSolrClient(MiniSolrCloudCluster cluster) --> 11 usages in 8 files Begs for an instance method on MiniSolrCloudCluster then :-). Also, I'd much prefer "new" instead of "get" because it's a new object that must be closed by the caller. "get" implies zero responsibility on the caller's part as to the lifecycle. A best-practice, really. Yes there are other "get" methods violating this best-practice but leave for another day IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
