alessandrobenedetti commented on code in PR #1435:
URL: https://github.com/apache/solr/pull/1435#discussion_r1154179416
##########
solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java:
##########
@@ -171,57 +182,111 @@ public void parseVector_NotAList_shouldThrowException() {
"Single string value should throw an exception",
SolrException.class,
() -> {
- toTest.parseVector("string");
+ toTestFloatEncoding.getVectorBuilder("string").getFloatVector();
});
MatcherAssert.assertThat(
thrown.getMessage(),
is(
- "incorrect vector format."
- + " The expected format is an array :'[f1,f2..f3]' where each
element f is a float"));
+ "incorrect vector format. The expected format is:'[f1,f2..f3]'
where each element f is a float"));
+
+ thrown =
+ assertThrows(
+ "Single string value should throw an exception",
+ SolrException.class,
+ () -> {
+ toTestByteEncoding.getVectorBuilder("string").getByteVector();
+ });
+ MatcherAssert.assertThat(
+ thrown.getMessage(),
+ is(
+ "incorrect vector format. The expected format is:'[fb,b2..b3]'
where each element b is a byte (-128 to 127)"));
Review Comment:
same as above, I suspect there's a typo in the log message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
