alessandrobenedetti commented on code in PR #1435:
URL: https://github.com/apache/solr/pull/1435#discussion_r1154182662
##########
solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java:
##########
@@ -253,10 +332,17 @@ public void
parseVector_incorrectElement_shouldThrowException() {
*/
@Test
public void parseVector_StringArrayList_shouldParseFloatArray() {
- toTest = new DenseVectorField(3);
float[] expected = new float[] {1.1f, 2.2f, 3.3f};
+ MatcherAssert.assertThat(
+ toTestFloatEncoding.getVectorBuilder(Arrays.asList(1.1f, 2.2f,
3.3f)).getFloatVector(),
+ is(expected));
+ }
- MatcherAssert.assertThat(toTest.parseVector(Arrays.asList("1.1", "2.2",
"3.3")), is(expected));
+ @Test
+ public void parseVector_StringArrayList_shouldParseByteArray() {
+ BytesRef expected = newBytesRef(new byte[] {1, 2, 3});
+ MatcherAssert.assertThat(
+ toTestByteEncoding.getVectorBuilder(Arrays.asList(1, 2,
3)).getByteVector(), is(expected));
Review Comment:
should be list of string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
