[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1525: SOLR-16732: misc sonar fixes

via GitHub Sat, 01 Apr 2023 09:31:50 -0700


sonatype-lift[bot] commented on code in PR #1525:
URL: https://github.com/apache/solr/pull/1525#discussion_r1155139851



##########
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java:
##########
@@ -190,7 +190,7 @@ public static void clearSolrDisableShardsWhitelist() throws 
Exception {
 
   private static String getHostContextSuitableForServletContext() {
     String ctx = System.getProperty("hostContext", "/solr");
-    if ("".equals(ctx)) ctx = "/solr";
+    if (ctx != null && ctx.isEmpty()) ctx = "/solr";
     if (ctx.endsWith("/")) ctx = ctx.substring(0, ctx.length() - 1);

Review Comment:
   <picture><img alt="14% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/14/display.svg";></picture>
   
   <b>*NULL_DEREFERENCE:</b>*  object `ctx` last assigned on line 192 could be 
null and is dereferenced at line 194.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
   
   Was this a good recommendation for you? <sub><small>Answering this survey 
will not impact your Lift settings.</small></sub>
   
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=469397528&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=469397528&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=469397528&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=469397528&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=469397528&lift_comment_rating=5)
 ]



##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -197,16 +197,16 @@ public static String resolve(
     if (defaults != null) {
       for (String param : defaults.keySet()) {
         str =
-            str.replaceAll(
-                "\\$\\{" + param + "\\}",
+            str.replace(
+                "${" + param + "}",
                 overrides.containsKey(param) ? overrides.get(param) : 
defaults.get(param));
       }
     }
     for (String param : overrides.keySet()) {
-      str = str.replaceAll("\\$\\{" + param + "\\}", overrides.get(param));
+      str = str.replace("${" + param + "}", overrides.get(param));
     }
     for (String param : systemParams.keySet()) {
-      str = str.replaceAll("\\$\\{" + param + "\\}", systemParams.get(param));
+      str = str.replace("${" + param + "}", systemParams.get(param));

Review Comment:
   <picture><img alt="10% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/10/display.svg";></picture>
   
   <b>*INEFFICIENT_KEYSET_ITERATOR:</b>*  Accessing a value using a key that 
was retrieved from a `keySet` iterator. It is more efficient to use an iterator 
on the `entrySet` of the map, avoiding the extra `HashMap.get(key)` lookup.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
   
   Was this a good recommendation for you? <sub><small>Answering this survey 
will not impact your Lift settings.</small></sub>
   
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=469397553&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=469397553&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=469397553&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=469397553&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=469397553&lift_comment_rating=5)
 ]



##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -197,16 +197,16 @@ public static String resolve(
     if (defaults != null) {
       for (String param : defaults.keySet()) {
         str =
-            str.replaceAll(
-                "\\$\\{" + param + "\\}",
+            str.replace(
+                "${" + param + "}",
                 overrides.containsKey(param) ? overrides.get(param) : 
defaults.get(param));
       }
     }
     for (String param : overrides.keySet()) {
-      str = str.replaceAll("\\$\\{" + param + "\\}", overrides.get(param));
+      str = str.replace("${" + param + "}", overrides.get(param));

Review Comment:
   <picture><img alt="10% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/10/display.svg";></picture>
   
   <b>*INEFFICIENT_KEYSET_ITERATOR:</b>*  Accessing a value using a key that 
was retrieved from a `keySet` iterator. It is more efficient to use an iterator 
on the `entrySet` of the map, avoiding the extra `HashMap.get(key)` lookup.
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
   
   Was this a good recommendation for you? <sub><small>Answering this survey 
will not impact your Lift settings.</small></sub>
   
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=469397823&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=469397823&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=469397823&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=469397823&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=469397823&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1525: SOLR-16732: misc sonar fixes

Reply via email to