dsmiley commented on code in PR #1525:
URL: https://github.com/apache/solr/pull/1525#discussion_r1155380008
##########
solr/core/src/java/org/apache/solr/core/CoreDescriptor.java:
##########
@@ -211,9 +211,11 @@ public CoreDescriptor(
if (isUserDefinedProperty(propname))
originalExtraProperties.put(propname, propvalue);
else originalCoreProperties.put(propname, propvalue);
- if (!requiredProperties.contains(propname)) // Required props are
already dealt with
- coreProperties.setProperty(
+ // Required props are already dealt with
Review Comment:
Glad you are fixing this. It's bizarre that GJF doesn't detect/fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
