HoustonPutman commented on code in PR #1535:
URL: https://github.com/apache/solr/pull/1535#discussion_r1156225049
##########
solr/modules/s3-repository/src/test/org/apache/solr/s3/S3PathsTest.java:
##########
@@ -48,7 +48,7 @@ public void testFiles() throws S3Exception {
public void testDirectory() throws S3Exception {
client.createDirectory("/simple-directory");
- assertTrue(client.pathExists("/simple-directory"));
+ assertFalse("Dir path needs a trailing slash",
client.pathExists("/simple-directory"));
Review Comment:
So the integration tests work when I changed one line (which I have pushed),
so this _should_ be good, though we have seen other strange errors that the
integration tests didn't address. But overall I think we should be good here.
directories are generally always treated as directories in the actual backup
code...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
