risdenk commented on code in PR #1535:
URL: https://github.com/apache/solr/pull/1535#discussion_r1156308451
##########
solr/modules/s3-repository/src/test/org/apache/solr/s3/S3PathsTest.java:
##########
@@ -48,7 +48,7 @@ public void testFiles() throws S3Exception {
public void testDirectory() throws S3Exception {
client.createDirectory("/simple-directory");
- assertTrue(client.pathExists("/simple-directory"));
+ assertFalse("Dir path needs a trailing slash",
client.pathExists("/simple-directory"));
Review Comment:
> I don't think the hdfs failures were related to the change (the tests
wouldn't even start)
ut oh... I'll take a closer look at this since I just upgrade Hadoop to
3.3.5... I haven't seen any Jenkins failures related to it though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
