risdenk commented on code in PR #1600:
URL: https://github.com/apache/solr/pull/1600#discussion_r1181828544
##########
solr/bin/solr:
##########
@@ -746,7 +750,6 @@ function run_tool() {
# get status about any Solr nodes running on this host
function get_status() {
- CODE=4
Review Comment:
My guess is it was supposed to be used in `exit` here -
https://github.com/apache/solr/blob/11a86934f4c36f823c0a917fe7c5348b0aa96f57/solr/bin/solr#L966
but was never wired up correctly.
the idea being that exit codes for non successful commands would be set
properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
