janhoy commented on PR #1615: URL: https://github.com/apache/solr/pull/1615#issuecomment-1531093512
Did a quick browse, looks good. I agree that this change is acceptable in a minor release, for the reasons given. @chatman, I think it makes sense to keep the core-level settings and APIs as no-ops in 9.x, declare them as deprecated in 9x and remove in main branch only. For all the test-solrconfig.xml files I think we can do a global search/replace `<requestParsers.*?enableRemoteStreaming=".*?"` with `<requestParsers` and the same with stream body, as these are no-op anyway now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
