janhoy commented on PR #1615: URL: https://github.com/apache/solr/pull/1615#issuecomment-1531509376
> Why modify solr.in.sh at all? I'd rather not; to be honest, I'd rather that file not exist at all (by default). All lines in solr.in.sh are commented, so it is not needed by default. But the reason I'd prefer all sysprops to have their own ENV equivalent is for ease of configuration in e.g. Docker / k8s as a simple env.var instead of having to do `SOLR_OPTS` concatenation. > @dsmiley , there's already "-Dsolr.environment=prod" in Solr. Yes, I put it in there, and all it does now is change color in Admin UI between envs :) We could certainly re-use it to set defaults for other things. But do we want remote streaming to be enabled by default in dev/test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
