MarcusSorealheis commented on code in PR #1629:
URL: https://github.com/apache/solr/pull/1629#discussion_r1187022006
##########
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##########
@@ -403,12 +403,12 @@ public String getIndexDir() {
/**
* Returns the indexdir as given in index.properties. If index.properties
exists in dataDir and
- * there is a property <i>index</i> available and it points to a valid
directory in dataDir that
+ * there is a property <i>index</i> available, and it points to a valid
directory in dataDir that
* is returned. Else dataDir/index is returned. Only called for creating new
indexSearchers and
* indexwriters. Use the getIndexDir() method to know the active index
directory
*
* @return the indexdir as given in index.properties
- * @throws SolrException if for any reason the a reasonable index directory
cannot be determined.
+ * @throws SolrException if for any reason a reasonable index directory
cannot be determined.
Review Comment:
should this comment simply be:
`@throws SolrException if for any reason an index directory cannot be
determined.`
##########
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepositoryFactory.java:
##########
@@ -78,7 +78,7 @@ public BackupRepository newInstance(SolrResourceLoader
loader, String name) {
BackupRepository result = loader.newInstance(repo.className,
BackupRepository.class);
if ("trackingBackupRepository".equals(name)) {
// newInstance can be called by multiple threads, synchronization
prevents simultaneous
- // multi-threaded 'adds' from corrupting the namedlist
+ // multithreaded 'adds' from corrupting the namedlist
Review Comment:
echoing @janhoy, I appreciate the attention to detail.
While we are at it, do you think it would be too much to ask to change the
mentions of `namedList` in the comments to follow their used convention,
`namedList`? This change would be important for users searching the code base
here with case sensitivity enabled, which is quite common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
