MarcusSorealheis commented on code in PR #1629:
URL: https://github.com/apache/solr/pull/1629#discussion_r1187024838
##########
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepositoryFactory.java:
##########
@@ -78,7 +78,7 @@ public BackupRepository newInstance(SolrResourceLoader
loader, String name) {
BackupRepository result = loader.newInstance(repo.className,
BackupRepository.class);
if ("trackingBackupRepository".equals(name)) {
// newInstance can be called by multiple threads, synchronization
prevents simultaneous
- // multi-threaded 'adds' from corrupting the namedlist
+ // multithreaded 'adds' from corrupting the namedlist
Review Comment:
echoing @janhoy, I appreciate the attention to detail.
While we are at it, do you think it would be too much to ask to change the
mentions of `namedList` in the comments to follow their used convention,
`namedList`? This change would be important for users searching the codebase
here with case sensitivity enabled, which is quite common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
