HoustonPutman commented on code in PR #1545:
URL: https://github.com/apache/solr/pull/1545#discussion_r1223432350
##########
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java:
##########
@@ -228,9 +228,20 @@ default void copyIndexFileFrom(
* Delete {@code files} at {@code path}
*
* @since 8.3.0
+ * @deprecated Use {@link #delete(URI, Collection)} instead
Review Comment:
So I think we kind of need it to be the opposite. For people who have custom
BackupRepositories, this isn't back-compat. They will need to change their
Repository to have this new method.
Maybe for 9.x we make the implementation details, but don't add the new
method. And then `ignoreNoSuchFileException` will just be ignored.
For 10x, change it to the new method, and just remove the old one.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
