HoustonPutman commented on code in PR #1545:
URL: https://github.com/apache/solr/pull/1545#discussion_r1223440389
##########
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java:
##########
@@ -228,9 +228,20 @@ default void copyIndexFileFrom(
* Delete {@code files} at {@code path}
*
* @since 8.3.0
+ * @deprecated Use {@link #delete(URI, Collection)} instead
Review Comment:
The default implementation will throw an error, so custom repositories will
fail by default when they upgrade to 9.3 (without compilation errors, which are
better than runtime errors).
How about we change all usages of `delete(path, files, bool)` internally to
use `delete(path, files)`, and have `delete(path, files)` default to
`delete(path, files, false)`. Then in `main`, we can remove `delete(path,
files, bool)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
