dsmiley commented on code in PR #1680:
URL: https://github.com/apache/solr/pull/1680#discussion_r1223608343
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -193,12 +193,24 @@ public void checkSchemaField(final SchemaField field)
throws SolrException {
switch (vectorEncoding) {
case FLOAT32:
if (dimension > FloatVectorValues.MAX_DIMENSIONS) {
- log.warn("The vector dimension "+ dimension +" specified for field
"+ field.getName() +" exceeds the current Lucene default max dimension of "+
FloatVectorValues.MAX_DIMENSIONS +". It's un-tested territory, extra caution
and benchmarks are recommended for production systems.");
+ if (log.isWarnEnabled()) {
Review Comment:
I am unaware Errorprone cares; can you provide a more specific reference
please?
Our build has custom checks defined with Groovy in our Gradle build. Maybe
you meant that? Erick Erickson was once burned by a debug log statement that
had some arguments that were expensive to compute... and ever since he added
these checks, we can no longer have the one-line convenience of a debug log
message, not even in a test :-( (I'm not a fan TBH; cure was worse than what it
was fixing IMO).
https://github.com/apache/solr/blob/7a9ce356bc7c90c8237437b1e16ed030e4d67900/gradle/validation/validate-log-calls.gradle#L110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
