alessandrobenedetti commented on code in PR #1680:
URL: https://github.com/apache/solr/pull/1680#discussion_r1224052278
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -193,12 +193,24 @@ public void checkSchemaField(final SchemaField field)
throws SolrException {
switch (vectorEncoding) {
case FLOAT32:
if (dimension > FloatVectorValues.MAX_DIMENSIONS) {
- log.warn("The vector dimension "+ dimension +" specified for field
"+ field.getName() +" exceeds the current Lucene default max dimension of "+
FloatVectorValues.MAX_DIMENSIONS +". It's un-tested territory, extra caution
and benchmarks are recommended for production systems.");
+ if (log.isWarnEnabled()) {
Review Comment:
I didn't add the if check at the beginning but Gradle complained, do you
believe I should ignore that and revert to the simple warn line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
