[
https://issues.apache.org/jira/browse/SOLR-16829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741173#comment-17741173
]
Jason Gerlowski commented on SOLR-16829:
----------------------------------------
Woohoo! Appreciate your guys' attention to this corner of the code [~epugh]
[~willdotwhite]!
bq. I think there is potentially some debate on backporting these changes to
the 9x line or not?
I'm not sure what the right answer is in terms of backporting, but I do have
some concerns around the backcompat implications that tie into that discussion
(whichever way that goes) I went into [a bit of detail on the
PR|https://github.com/apache/solr/pull/1670#pullrequestreview-1519461289]
earlier today, but I'll try to summarize my concerns here as well.
The PR doesn't just refactor how argparsing and "help" are done, it changes the
syntax for several bin/solr tools. So, my concerns around that, in short:
* If we *do* backport it to branch_9x:
** we should make sure that both the old and new syntaxes are supported, so
that users don't find their tooling broken upon doing a "minor" upgrade.
* If we *don't* backport it to branch_9x:
** We're clear of any backcompat requirements, strictly speaking. (Though IMO
it's still a bad user-experience if we don't overlap support for the old and
new syntaxes at all to give users time to update their tooling to the new
syntax, etc). At a bare minimum though, the CHANGES.txt entry for this work
needs updated to summarize the syntax changes. There's currently no mention of
the syntax-shift in CHANGES.txt, Upgrade Notes, etc. afaict.
> Refactor bin/solr and bin/solr.cmd to delegate usage help to SolrCLI
> --------------------------------------------------------------------
>
> Key: SOLR-16829
> URL: https://issues.apache.org/jira/browse/SOLR-16829
> Project: Solr
> Issue Type: Sub-task
> Components: cli
> Affects Versions: 9.2.1
> Reporter: Eric Pugh
> Priority: Minor
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
