anshumg commented on code in PR #65:
URL: https://github.com/apache/solr-sandbox/pull/65#discussion_r1304810287
##########
crossdc-producer/src/main/java/org/apache/solr/update/processor/MirroringUpdateRequestProcessorFactory.java:
##########
@@ -152,6 +149,22 @@ public void inform(SolrCore core) {
KafkaCrossDcConf.readZkProps(properties, zkProps);
}
+ CollectionProperties cp = new
CollectionProperties(core.getCoreContainer().getZkController().getZkClient());
Review Comment:
Let's extract this out into a method? `isCrossDcEnabled()` or something?
##########
crossdc-consumer/build.gradle:
##########
@@ -60,8 +60,8 @@ dependencies {
exclude group: "org.apache.logging.log4j", module: "*"
exclude group: "org.slf4j", module: "*"
}
- testImplementation 'org.apache.kafka:kafka_2.13:2.8.1'
Review Comment:
this change seems unrelated
##########
crossdc-producer/src/test/java/org/apache/solr/crossdc/SolrAndKafkaMultiCollectionIntegrationTest.java:
##########
@@ -169,6 +181,14 @@ public void testFullCloudToCloudMultiCollection() throws
Exception {
solrCluster2.getSolrClient().request(create);
solrCluster2.waitForActiveCollection(ALT_COLLECTION, 1, 1);
+ // Update the collection property "enabled" to true
+ CollectionProperties cp = new
CollectionProperties(solrCluster1.getZkClient());
+ cp.setCollectionProperty(ALT_COLLECTION, "crossdc.enabled", "true");
+ cp.setCollectionProperty(ALT_COLLECTION, "crossdc.topicName", TOPIC);
Review Comment:
It seems like we're testing the fetching of the correct topic name,
something that we can change at run time but I'm viewing this on the browser.
Can you confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
