gerlowskija commented on code in PR #65:
URL: https://github.com/apache/solr-sandbox/pull/65#discussion_r1305629572
##########
crossdc-producer/src/main/java/org/apache/solr/update/processor/MirroringUpdateRequestProcessorFactory.java:
##########
@@ -152,6 +149,22 @@ public void inform(SolrCore core) {
KafkaCrossDcConf.readZkProps(properties, zkProps);
}
+ CollectionProperties cp = new
CollectionProperties(core.getCoreContainer().getZkController().getZkClient());
+ Map<String,String> collectionProperties =
cp.getCollectionProperties(core.getCoreDescriptor().getCollectionName());
+ for (ConfigProperty configKey :
KafkaCrossDcConf.CONFIG_PROPERTIES) {
+ String val = collectionProperties.get("crossdc." +
configKey.getKey());
+ if (val != null && !val.isBlank()) {
+ properties.put(configKey.getKey(), val);
+ }
+ }
+ String enabledVal = collectionProperties.get("crossdc.enabled");
Review Comment:
[0] We should probably document these special collection properties in
Javadocs at the least, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
