HoustonPutman commented on code in PR #1920:
URL: https://github.com/apache/solr/pull/1920#discussion_r1324732362
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -299,8 +299,9 @@ public MiniSolrCloudCluster(
.withUrl(zkServer.getZkHost())
.withTimeout(AbstractZkTestCase.TIMEOUT, TimeUnit.MILLISECONDS)
.build()) {
- if (!zkClient.exists("/solr/solr.xml", true)) {
- zkClient.makePath("/solr/solr.xml",
solrXml.getBytes(Charset.defaultCharset()), true);
+ // NOCOMMIT: Create chroot here, not sure why it is now necessary?
+ zkClient.makePath("/solr", false, true);
Review Comment:
Hmm, you would hope the code in
[SOLR-7642](https://issues.apache.org/jira/browse/SOLR-7642) would make this
unnecessary... Or is it because of the `zkClient.MakePath()` code below? weird
since that is the same code as was deleted for `solr.xml`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
