[
https://issues.apache.org/jira/browse/SOLR-16974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765048#comment-17765048
]
Jan Høydahl edited comment on SOLR-16974 at 9/14/23 8:15 AM:
-------------------------------------------------------------
Would be nice to be able to configure these without editing solr.xml, with
optional env.vars in solr.in.sh, something like
{code:java}
# Define global circuit breakers for update requests
SOLR_CIRCUITBREAKER_UPDATE_CPU=80
SOLR_CIRCUITBREAKER_UPDATE_MEM=80
SOLR_CIRCUITBREAKER_UPDATE_LOADAVG=250
# Define global circuit breakers for query requests
SOLR_CIRCUITBREAKER_QUERY_CPU=90
SOLR_CIRCUITBREAKER_QUERY_MEM=90
SOLR_CIRCUITBREAKER_QUERY_LOADAVG=250{code}
These would configure the built-in ones. If users provide their own custom
implementations they can of course still plugin them in by xml. Wdyt?
was (Author: janhoy):
Would be nice to be able to configure these without editing solr.xml, with
optional env.vars in solr.in.sh, something like
{code:java}
SOLR_CIRCUITBREAKER_UPDATE_CPU=80
SOLR_CIRCUITBREAKER_UPDATE_MEM=80
SOLR_CIRCUITBREAKER_UPDATE_LOADAVG=80
SOLR_CIRCUITBREAKER_QUERY_CPU=90
SOLR_CIRCUITBREAKER_QUERY_MEM=90
SOLR_CIRCUITBREAKER_QUERY_LOADAVG=90{code}
These would configure the built-in ones. If users provide their own custom
implementations they can of course still plugin them in by xml. Wdyt?
> Global Circuit Breakers
> -----------------------
>
> Key: SOLR-16974
> URL: https://issues.apache.org/jira/browse/SOLR-16974
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Circuit Breakers
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently Circuit Breakers are configured per core in solrconfig.xml.
> However, cores/collections do not live in isolation, and it could be that a
> cluster administrator would like to enforce circuit breakers for the entire
> cluster.
> I'm not clear as to whether we need both cluster level and a core level
> pluggability. And would core-level breakers add to any cluster-level ones or
> override them for that core?
> A potential design is to add this as a new plugin in solr.xml, and have them
> added in a new static context of CircuitBreakerRegistry. Then the isTripped
> logic would consult both the per-core list and the static/global list of
> breakers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
