[
https://issues.apache.org/jira/browse/SOLR-16974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767592#comment-17767592
]
Walter Underwood commented on SOLR-16974:
-----------------------------------------
Global circuit breakers make sense because these are global metrics. I'm can
come up with examples for core-level circuit breakers from my experience, but
they are not convincing.
If we have two collections, one for autosuggest and one for the search results
page, it is clearly lower-impact to trip the circuit breaker on the autosuggest
collection compared to the SRP collection. But...autosuggest will be fast, not
using much CPU, so a circuit breaker there won't relieve much pressure on the
CPU. So, not a convincing example.
For our clusters, we don't deploy solr.xml, we use the built-in default one. So
we would need to mess with our deployment to use global circuit breakers.
Probably not quite worth the effort to switch to global ones for our uses, even
if they are a cleaner solution.
> Global Circuit Breakers
> -----------------------
>
> Key: SOLR-16974
> URL: https://issues.apache.org/jira/browse/SOLR-16974
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Circuit Breakers
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently Circuit Breakers are configured per core in solrconfig.xml.
> However, cores/collections do not live in isolation, and it could be that a
> cluster administrator would like to enforce circuit breakers for the entire
> cluster.
> I'm not clear as to whether we need both cluster level and a core level
> pluggability. And would core-level breakers add to any cluster-level ones or
> override them for that core?
> A potential design is to add this as a new plugin in solr.xml, and have them
> added in a new static context of CircuitBreakerRegistry. Then the isTripped
> logic would consult both the per-core list and the static/global list of
> breakers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
