epugh commented on code in PR #1951:
URL: https://github.com/apache/solr/pull/1951#discussion_r1335002068
##########
solr/bin/solr:
##########
@@ -148,7 +148,7 @@ fi
: "${SOLR_START_WAIT:=$SOLR_STOP_WAIT}" # defaulting to $SOLR_STOP_WAIT for
backwards compatibility reasons
# Store whether a solr port was explicitly provided, for the "solr stop"
command.
-PROVIDED_SOLR_PORT="${SOLR_PORT:-}"
+PROVIDED_SOLR_PORT_ENV="${SOLR_PORT:-}"
Review Comment:
is `_ENV` a pattern we use elsewhere in `bin/solr`? For these variables?
If we have similar concepts, maybe we can get all of the variables following
this pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
