epugh commented on code in PR #1951:
URL: https://github.com/apache/solr/pull/1951#discussion_r1335003644
##########
solr/bin/solr:
##########
@@ -1143,17 +1132,7 @@ if [[ "$SCRIPT_CMD" == "auth" ]]; then
AUTH_PARAMS=("${AUTH_PARAMS[@]}" "-solrIncludeFile" "$SOLR_INCLUDE")
- if [ -z "${AUTH_PORT:-}" ]; then
- for ID in $(ps auxww | grep java | grep start\.jar | awk '{print $2}' |
sort -r)
- do
- port=$(jetty_port "$ID")
- if [ "$port" != "" ]; then
- AUTH_PORT=$port
- break
- fi
- done
- fi
- run_tool auth "${AUTH_PARAMS[@]}" -solrUrl
"$SOLR_URL_SCHEME://$SOLR_TOOL_HOST:${AUTH_PORT:-8983}/solr" -authConfDir
"$SOLR_HOME" $VERBOSE
+ run_tool auth "${AUTH_PARAMS[@]}" -authConfDir "$SOLR_HOME" $VERBOSE
Review Comment:
Also, I was noticing in `bin/solr auth` getting the warning about the
solrUrl not needing `/solr` and this fixes it, assuming we aren't constructing
a solr url internally with a trailing `/solr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
