epugh commented on code in PR #1954:
URL: https://github.com/apache/solr/pull/1954#discussion_r1342625748
##########
solr/core/src/java/org/apache/solr/cli/AssertTool.java:
##########
@@ -123,6 +123,14 @@ public List<Option> getOptions() {
Option.builder("e")
.desc("Return an exit code instead of printing error message on
assert fail.")
.longOpt("exitcode")
+ .build(),
+ // u was taken, can we change that instead?
+ Option.builder("credentials")
Review Comment:
Because the `u` short option is already used elsewhere in the assert tool....
##########
solr/core/src/java/org/apache/solr/cli/PackageTool.java:
##########
@@ -342,6 +341,14 @@ public List<Option> getOptions() {
.required(false)
.desc("Don't prompt for input; accept all default choices,
defaults to false.")
.longOpt("noprompt")
+ .build(),
+ // u was taken, can we change that instead?
+ Option.builder("credentials")
Review Comment:
likewise, the `u` already used...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
