epugh commented on code in PR #1954:
URL: https://github.com/apache/solr/pull/1954#discussion_r1342785865
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1311,6 +1311,22 @@ public Builder withProxyConfiguration(
this.proxyIsSecure = isSecure;
return this;
}
+
+ /**
+ * Setup basic authentication from a string formatted as
username:password. If the string is
+ * Null then it doesn't do anything.
+ *
+ * @param credentials The username and password formatted as
username:password
+ * @return this Builder
+ */
+ public Builder withOptionalBasicAuthCredentials(String credentials) {
Review Comment:
```
throw new IllegalStateException(
"Invalid Authentication credentials. Either both username and
password or none must be provided");
```
this appears to be a pattern in other builders...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
