risdenk commented on code in PR #1769:
URL: https://github.com/apache/solr/pull/1769#discussion_r1344543174
##########
gradle/validation/jar-checks.gradle:
##########
@@ -122,17 +122,24 @@ subprojects {
}
def visited = new HashSet<>()
+ def seenDeps = new HashSet<>()
def infos = []
while (!queue.isEmpty()) {
def dep = queue.removeFirst()
+ seenDeps.add(dep)
// Skip any artifacts from other Solr Modules (they will be resolved
there).
if (dep.moduleGroup == "org.apache.solr") {
continue
}
- queue.addAll(dep.children)
+ // Make sure we don't keep visiting the same children over and over
again
Review Comment:
For completeness here is some debugging done in ASF slack but the root cause
is grpc having a cyclic dependency when we don't account for runtime and
compile dependencies separately.
https://mvnrepository.com/artifact/io.grpc/grpc-core/1.58.0
depends on grpc-util as runtime dependency
https://mvnrepository.com/artifact/io.grpc/grpc-util/1.58.0
depends on grpc-core as compile dependency
and grpc-util is new in 1.58.0 -
https://mvnrepository.com/artifact/io.grpc/grpc-util
https://github.com/grpc/grpc-java/issues/10576
the issue that jar checks everything - both runtime and compile so thats the
loop issue.
based on the comments its not REALLY an issue since compile and runtime can
coexist like that but its just our jar-checks that has an issue w/ it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
