risdenk commented on code in PR #1769:
URL: https://github.com/apache/solr/pull/1769#discussion_r1344546479
##########
gradle/validation/jar-checks.gradle:
##########
@@ -122,17 +122,24 @@ subprojects {
}
def visited = new HashSet<>()
+ def seenDeps = new HashSet<>()
def infos = []
while (!queue.isEmpty()) {
def dep = queue.removeFirst()
+ seenDeps.add(dep)
// Skip any artifacts from other Solr Modules (they will be resolved
there).
if (dep.moduleGroup == "org.apache.solr") {
continue
}
- queue.addAll(dep.children)
+ // Make sure we don't keep visiting the same children over and over
again
Review Comment:
This same thing exists in
https://github.com/apache/lucene/blob/main/gradle/validation/jar-checks.gradle#L115
so will open a PR there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
