risdenk commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1352582118
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/BeforeReconnect.java:
##########
@@ -16,6 +16,17 @@
*/
package org.apache.solr.common.cloud;
-public interface BeforeReconnect {
+import org.apache.curator.framework.CuratorFramework;
+import org.apache.curator.framework.state.ConnectionState;
+import org.apache.curator.framework.state.ConnectionStateListener;
+
+public interface BeforeReconnect extends ConnectionStateListener {
public void command();
+
+ @Override
+ default void stateChanged(CuratorFramework client, ConnectionState newState)
{
Review Comment:
I really don't know if this is right. Its just like OnDisconnect which seems
wrong but tests pass :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
