magibney commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-1757964761
> I propose we make the loss of the reconnect boolean its own PR, plus the methods that shielded use of ZkCmdExecutor. That will make this effort here more independently reviewable and would be nice in its own right. +1 to David's suggestion; this diff is pretty unwieldy. It's not too late to do this either -- we could just add 2 commits: one removing the strictly mechanical changes and then another commit immediately reverting the removal. Simply having the commits would allow creative diff'ing and patch-applying to make the PR easier to review. I'll probably do this locally anyway just to facilitate my own reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
