cpoerschke commented on PR #2059: URL: https://github.com/apache/solr/pull/2059#issuecomment-1792104596
> Ok, I forgot that I already had #1904 already open with almost exactly same changes. ... Ah, I had a vague "wasn't there a prior draft or wasn't this further down in the PR list" sense but didn't look beyond that. Thanks for finding the other PR! > ... But I wonder if git manages to do the right thing, understanding that the `BaseTestCircuitBreaker` class was renamed `TestCircuitBreaker`? I _think_ git will manage to do the right thing often in this situation, based on some sort of partial understanding of how git works underneath and the occasional "i'm surprised this worked" reaction in this kind of situation, but I'm no expert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
