janhoy commented on PR #2059: URL: https://github.com/apache/solr/pull/2059#issuecomment-1792346399
> > The only real diff is that #1904 had configurable error code ... > > Without the configurability seems simpler but given that `setErrorCode` is not annotated as deprecated (or final), need we retain it then or to deprecate it before removal? The [CircuitBreaker class](https://github.com/apache/solr/blob/branch_9x/solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java) does not have any `setErrorCode()` method, it was added in the other PR. I added it in this PR too, this time through sysprop `solr.circuitbreaker.errorcode` so users can actually configure it (globally). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
