cpoerschke commented on code in PR #2059:
URL: https://github.com/apache/solr/pull/2059#discussion_r1381683950
##########
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java:
##########
@@ -62,6 +64,16 @@ public CircuitBreaker() {}
/** Get error message when the circuit breaker triggers */
public abstract String getErrorMessage();
+ /**
+ * Get http error code, defaults to {@link
SolrException.ErrorCode#TOO_MANY_REQUESTS} but can be
+ * overridden with system property {@link
#SYSPROP_SOLR_CIRCUITBREAKER_ERRORCODE}
+ */
+ public static SolrException.ErrorCode getErrorCode() {
+ return SolrException.ErrorCode.getErrorCode(
+ Integer.getInteger(
+ SYSPROP_SOLR_CIRCUITBREAKER_ERRORCODE,
SolrException.ErrorCode.TOO_MANY_REQUESTS.code));
Review Comment:
Sorry, I missed this comment. The exception bubbling up could be confusing
for clients and operationally an exception or at least logging on startup could
be helpful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
