dsmiley commented on code in PR #2084:
URL: https://github.com/apache/solr/pull/2084#discussion_r1399267463
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/RejoinLeaderElectionPayload.java:
##########
@@ -26,13 +26,9 @@ public class RejoinLeaderElectionPayload implements
ReflectMapWriter {
// ones are meant to be required without that being specified on the v1 API
or elsewhere
@JsonProperty public String collection;
- @JsonProperty public String shard;
Review Comment:
Is this backwards-compatible? I'm not super familiar with this, but from
what I can see, there are some inputs that are no longer needed. It seems they
weren't really used before (yes?). What would happen if a client supplies it?
CC @gerlowskija you might know if this produces a failure or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
