dsmiley commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1847711918
I played a bit with my idea but it wasn't working out; perhaps because internal complexities around searcher lifecycle. I still don't understand why `getOpenCount() <= 1;` could be correct because a metrics request isn't going to increment the core count. Maybe we should change the initial value to 0 and increment at the end of the constructor; albeit it will then appear as "closed" during this time? A value of "-1" could be used to differentiate. I went to a test, MetricsHandlerTest.test and set a breakpoint to inspect its response, which is only partially validated. There are no validations for, say, "segments" (exposed as INDEX.segments), but if you look at the response in a debugger, there is a null value. It should instead be the number of segments. Obviously we have a testing gap here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
