stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1851332731
> But I do think we need a new test to show that "segments" can return a non-null value. I think it should work now but I observed it didn't work on your first try. Basically, a new assertion; maybe a few lines to the existing metrics test. agreed. I added a few trivial assertions to the test. > I think it's hard to tell when we can simply look at isClosed() vs isNotOpen(). Maybe let's have a new method on the core like isReady()? introduced `isReady()` and a best effort explanation as javadocs. please take a look and let me know if it can be explained better :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
