janhoy commented on code in PR #2162: URL: https://github.com/apache/solr/pull/2162#discussion_r1431049930
########## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ########## @@ -396,7 +392,7 @@ To ensure you avoid double-counting, do not choose both `lower` and `upper`, do |Optional |Default: none |=== + -The `facet.range.other` parameter specifies that in addition to the counts for each range constraint between `facet.range.start` and `facet.range.end`, counts should also be computed for these options: +In addition to the counts for each range constraint between `facet.range.start` and `facet.range.end`, counts should also be computed for these options: Review Comment: ```suggestion In addition to the counts for each range constraint between `facet.range.start` and `facet.range.end`, counts will also be computed for these options: ``` ########## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ########## @@ -149,7 +147,7 @@ Note that the default logic is changed when <<Limiting Facet with Certain Terms> |Optional |Default: `100` |=== + -This parameter specifies the maximum number of constraint counts (essentially, the number of facets for a field that are returned) that should be returned for the facet fields. +The number of facets for a field that are returned. Review Comment: "facets" is a bit overloaded here, perhaps use "count" or "size"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
