cpoerschke commented on code in PR #2162: URL: https://github.com/apache/solr/pull/2162#discussion_r1439672251
########## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ########## @@ -113,7 +113,7 @@ This does not limit the query in any way, only the facets that would be returned |Optional |Default: none |=== + -If `facet.contains` is used, the `facet.contains.ignoreCase` parameter causes case to be ignored when matching the given substring against candidate facet terms. +Causes case to be ignored when matching the `facet.contains` substring against candidate facet terms. Review Comment: nit/subjective ```suggestion If set to `true`, causes case to be ignored when matching the `facet.contains` substring against candidate facet terms. ``` ########## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ########## @@ -149,7 +147,7 @@ Note that the default logic is changed when <<Limiting Facet with Certain Terms> |Optional |Default: `100` |=== + -This parameter specifies the maximum number of constraint counts (essentially, the number of facets for a field that are returned) that should be returned for the facet fields. +The number of facet counts returned. A negative value means that Solr will return unlimited number of constraint counts. Review Comment: ```suggestion A negative value means that Solr will return all counts. ``` ########## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ########## @@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the list of constraints to |Optional |Default: `0` |=== + -The `facet.mincount` parameter specifies the minimum counts required for a facet field to be included in the response. +The minimum count required for a facet field to be included in the response. If a field's counts are below the minimum, the field's facet is not returned. Review Comment: Wondering about "field" versus "term" wording here. WDYT? ```suggestion The minimum count required for a facet field term to be included in the response. If a term's count is below the minimum, the term is not returned. ``` ########## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ########## @@ -187,7 +185,7 @@ If set to `true`, this parameter indicates that, in addition to the Term-based c |Optional |Default: `fc` |=== + -The `facet.method` parameter selects the type of algorithm or method Solr should use when faceting a field. +Selects the type of algorithm or method Solr should use when faceting a field. Review Comment: ```suggestion Selects the type of algorithm or method to use when faceting a field. ``` ########## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ########## @@ -131,12 +131,10 @@ If you want to only return facet buckets for the terms that match a regular expr |Optional |Default: none |=== + -This parameter determines the ordering of the facet field constraints. +The ordering of the facet field constraints. There are two options: Review Comment: ```suggestion The ordering of the facet field terms. There are two options: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
