cpoerschke commented on code in PR #2176:
URL: https://github.com/apache/solr/pull/2176#discussion_r1446374641
##########
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##########
@@ -111,7 +111,12 @@ public static LeafReader wrap(IndexReader reader) throws
IOException {
}
int createdVersionMajor =
reader.leaves().get(0).reader().getMetaData().getCreatedVersionMajor();
- metaData = new LeafMetaData(createdVersionMajor, minVersion, null);
+ metaData =
+ new LeafMetaData(
+ createdVersionMajor,
+ minVersion,
+ null,
+ reader.leaves().get(0).reader().getMetaData().hasBlocks());
Review Comment:
minor/subjective: `reader.leaves().get(0).reader().getMetaData()` assignment
to a local variable so that both the `createdVersionMajor` compute above and
the `hasBlock` determination here can use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
