psalagnac commented on code in PR #2176:
URL: https://github.com/apache/solr/pull/2176#discussion_r1447433615
##########
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##########
@@ -109,9 +109,10 @@ public static LeafReader wrap(IndexReader reader) throws
IOException {
minVersion = leafVersion;
}
}
- int createdVersionMajor =
-
reader.leaves().get(0).reader().getMetaData().getCreatedVersionMajor();
- metaData = new LeafMetaData(createdVersionMajor, minVersion, null);
+ LeafMetaData leafMetaData =
reader.leaves().get(0).reader().getMetaData();
+ metaData =
+ new LeafMetaData(
+ leafMetaData.getCreatedVersionMajor(), minVersion, null,
leafMetaData.hasBlocks());
Review Comment:
Out of curiosity, why don't we also specify the `sort` parameter here (3rd
parameter)? It could be retrieved from existing leaf metadata (this is not new
with this change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
