gerlowskija opened a new pull request, #2229: URL: https://github.com/apache/solr/pull/2229
https://issues.apache.org/jira/browse/SOLR-17066 # Description SOLR-17066 added a 'defaultCollection' field to each SolrClient implementation, similar to the one that has long been in use for SolrJ's "cloud" clients. This default collection (or core) is used on a request-by-request basis to build the complete HTTP path, based on the value of SolrRequest.requiresCollection(). This is a particular challenge for GenericSolrRequest though, which can be used to make both collection-agnostic and collection-aware requests. # Solution This commit adds a GenericSolrRequest setter, `setRequiresCollection(boolean)`, to allow GSR users to specify which requests they would like the client-level default collection to be used on. It updates a number of GSR usages in the project to be a bit more explicit about whether they're making a collection/core/index request, or not. GSR.requiresCollection defaults to `false`, so this PR only touches those uses that _do_ requires a collection/core. # Tests Existing tests continue to pass. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
