gerlowskija commented on code in PR #2229:
URL: https://github.com/apache/solr/pull/2229#discussion_r1470520449
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -155,9 +155,12 @@ public static String getFileFromJarsAsString(List<Path>
jars, String filename) {
}
/** Returns JSON string from a given Solr URL */
- public static String getJsonStringFromUrl(SolrClient client, String path,
SolrParams params) {
+ public static String getJsonStringFromUrl(
Review Comment:
Yeah, the 'magic boolean' is less than ideal for sure. Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
