bruno-roustant commented on code in PR #2239:
URL: https://github.com/apache/solr/pull/2239#discussion_r1474555675
##########
solr/core/src/java/org/apache/solr/core/backup/repository/LocalFileSystemRepository.java:
##########
@@ -97,7 +100,7 @@ public URI resolve(URI baseUri, String... pathComponents) {
public void createDirectory(URI path) throws IOException {
Path p = Path.of(path);
if (!Files.exists(p, LinkOption.NOFOLLOW_LINKS)) {
- Files.createDirectory(p);
Review Comment:
The new LocalFileSystemRepositoryTest revealed a small bug here :)
The method contract is to create all the directories needed, including the
parents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
