bruno-roustant commented on code in PR #2239:
URL: https://github.com/apache/solr/pull/2239#discussion_r1478908242
##########
solr/modules/hdfs/src/java/org/apache/solr/hdfs/backup/repository/HdfsBackupRepository.java:
##########
@@ -204,6 +213,17 @@ public void copyIndexFileFrom(
}
}
+ @Override
Review Comment:
I agree, this method should be shared, but BackupRepository is an interface,
so I don't see how we share the sholdVerifyCheckum field. Unless we introduce
an abstract class in-between, something like AbstractBackupRepository, it that
what you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
