iamsanjay commented on code in PR #2247:
URL: https://github.com/apache/solr/pull/2247#discussion_r1480252120
##########
solr/core/src/java/org/apache/solr/search/CacheConfig.java:
##########
@@ -94,11 +95,8 @@ public static Map<String, CacheConfig> getMultipleConfigs(
}
public static CacheConfig getConfig(SolrConfig solrConfig, ConfigNode node,
String xpath) {
- if (!node.exists() || !"true".equals(node.attributes().get("enabled",
"true"))) {
- Map<String, Object> m =
solrConfig.getOverlay().getEditableSubProperties(xpath);
- if (m == null) return null;
- List<String> parts = StrUtils.splitSmart(xpath, '/');
- return getConfig(solrConfig, parts.get(parts.size() - 1),
Collections.emptyMap(), xpath);
Review Comment:
One more thing, earlier If `!node.exists()` returns false, we would check
whether if it has Overlay or not. But I believe we do not need to check for
Overlay anymore. Because when we call getConfig, we always check if it's
present in Overlay and then pass object wrapped in OverlaidConfigNode which
returns true by default, only return false, If it's empty node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
